fix: enable stickydisk again with new nix-installer-action#2017
fix: enable stickydisk again with new nix-installer-action#2017
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
jfroche
force-pushed
the
enable-eval-stickydisk-again
branch
3 times, most recently
from
a5de7bc to
83a3030
Compare
jfroche
force-pushed
the
enable-eval-stickydisk-again
branch
4 times, most recently
from
32b5257 to
ac3b13b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
jfroche
force-pushed
the
enable-eval-stickydisk-again
branch
from
ac3b13b to
1ae80af
Compare
| with: | ||
| install_url: https://releases.nixos.org/nix/nix-2.32.2/install | ||
| extra_nix_config: | | ||
| installer-version: 2.33.1 |
There was a problem hiding this comment.
will the newer version cause any conflict with using slightly older version elsewhere?
There was a problem hiding this comment.
No there are no breaking change in 2.33 but I could also upgrade the other references because 2.33 comes with nice performance improvements. It should also fix the problem we had with IPC leak on macos with postgres (see NixOS/nix#14459), we might want to tell people to upgrade nix on their macos laptop to avoid this.
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/actions/nix-install-ephemeral/action.yml (1)
43-50:⚠️ Potential issue | 🔴 CriticalAction and version references require correction.
The migration references
NixOS/nix-installer-action, but the standard (documented) nix-installer action isDeterminateSystems/nix-installer-action. Additionally,installer-version: 2.33.1appears incorrect—nix-installer uses0.xversioning (e.g.,0.23.0), not2.x. The value2.33.1matches Nix's version numbering, not the installer's, suggesting either a parameter mismatch or incorrect version reference.Verify:
- The correct action owner and commit SHA
- Whether
installer-versionshould reference a0.xversion or if this parameter should specify Nix version instead
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/actions/nix-install-ephemeral/action.yml (1)
43-50:⚠️ Potential issue | 🔴 CriticalRevert
installer-version: 2.33.2— this version does not exist in nix-installer releases.The
installer-versionparameter expects a version from the DeterminateSystems/nix-installer releases, which only provide v3.x versions (current latest: v3.15.2). The specified version 2.33.2 does not exist and will cause the workflow to fail at runtime.If 2.33.2 is the desired Nix version, use a valid nix-installer version (e.g.,
v3.15.2orlatest) instead. The installer version is separate from the Nix package manager version being installed.
🧹 Nitpick comments (1)
.github/workflows/base-image-nightly.yml (1)
37-43: Version bump looks correct, but note the installer action inconsistency.The Nix version bump to 2.33.2 is consistent with the PR objective. However, this workflow uses
cachix/install-nix-actionwithinstall_url, while.github/actions/nix-install-ephemeral/action.ymlwas migrated toNixOS/nix-installer-actionwithinstaller-version.If this inconsistency is intentional (e.g., different runner requirements), consider adding a comment explaining the choice. Otherwise, consider migrating this workflow to use the same installer action for consistency.
jfroche
force-pushed
the
enable-eval-stickydisk-again
branch
from
1b161c7 to
32aeb46
Compare
jfroche
force-pushed
the
enable-eval-stickydisk-again
branch
from
32aeb46 to
823b183
Compare
* fix: enable stickydisk again with new nix-installer-action * feat: use nix 2.33.1 everywhere
2 participants
Make sure the eval succeeds with both an empty /nix cache and a existing /nix cache.
Use the new nix installer.
Summary by CodeRabbit
Chores
Bug Fixes
Documentation